fix: all failing tests — test isolation, data race, flaky handoff #174

Merged

ash merged 3 commits from fix/test-isolation into main 2026-03-02 23:20:18 +00:00

Conversation 0 Commits 3 Files changed 4 +37 -5

ash commented 2026-03-02 23:20:10 +00:00

Owner

Copy link

Closes #173

All 16 packages pass with -race, zero failures.

1. cleanEvents() truncates shared events table before global reader tests
2. Mutex on memReader test helper (data race)
3. Poll loop replaces fixed sleep in handoff test (flaky)

Closes #173 All 16 packages pass with -race, zero failures. 1. cleanEvents() truncates shared events table before global reader tests 2. Mutex on memReader test helper (data race) 3. Poll loop replaces fixed sleep in handoff test (flaky)

ash added 3 commits 2026-03-02 23:20:10 +00:00

fix: test isolation for global reader tests ... 074e9ebbd5

Tests using PGGlobalReader (rebuild, SSE watch) read ALL events from the
shared events table. Events from other tests with different types cause
unmarshal failures, and non-contiguous IDs trigger the gap detector.

Add cleanEvents() helper that truncates the events table before tests
that use the global reader. Fixes TestRebuild_Postgres,
TestRebuildConcurrent_Postgres, and TestIntegration_SSE_PGStore_Watch.

fix: flaky TestLeaderLock_HandoffOnStop — use poll loop instead of fixed sleep ... e560d9e057

The 500ms sleep was sometimes not enough for lock handoff + poll cycle.
Replace with poll loop (50ms intervals, 3s deadline) for deterministic test.

fix: data race in memReader test helper — add mutex ... a915cc84e6

The memReader was accessed concurrently by test goroutines (append) and
subscription goroutines (ReadFrom/LatestSequence) without synchronization.

ash merged commit 18e15aef10 into main 2026-03-02 23:20:18 +00:00

ash referenced this pull request from a commit 2026-03-02 23:20:19 +00:00

Merge pull request 'fix: all failing tests — test isolation, data race, flaky handoff' (#174) from fix/test-isolation into main

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

bug

  

documentation

  

enhancement

  

investigation

  

nice-to-have

  

performance

  

production-ready

  

testing

No labels

bug

documentation

enhancement

investigation

nice-to-have

performance

production-ready

testing

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

ash/eskit!174

No description provided.