Fix all failing tests — test isolation, data race, flaky handoff #173

New issue

Closed

opened 2026-03-02 23:20:05 +00:00 by ash · 0 comments

ash commented

2026-03-02 23:20:05 +00:00

Owner

Three test failures:

TestRebuild_Postgres / TestRebuildConcurrent_Postgres — global reader reads ALL events from shared table, fails to unmarshal struct events as strings
TestIntegration_SSE_PGStore_Watch — gap detector blocks on non-contiguous IDs from other test runs
TestLeaderLock_HandoffOnStop — data race in memReader test helper + flaky fixed-sleep timing

Fixes:

cleanEvents() helper truncates events table before global reader tests
Mutex on memReader test helper
Poll loop instead of fixed sleep for handoff test

Three test failures: 1. **TestRebuild_Postgres / TestRebuildConcurrent_Postgres** — global reader reads ALL events from shared table, fails to unmarshal struct events as strings 2. **TestIntegration_SSE_PGStore_Watch** — gap detector blocks on non-contiguous IDs from other test runs 3. **TestLeaderLock_HandoffOnStop** — data race in memReader test helper + flaky fixed-sleep timing Fixes: - `cleanEvents()` helper truncates events table before global reader tests - Mutex on memReader test helper - Poll loop instead of fixed sleep for handoff test