fix: PgLockRegistry uses single shared connection for all advisory locks #172

Merged

ash merged 3 commits from fix/shared-advisory-conn into main 2026-03-02 23:12:16 +00:00

Conversation 0 Commits 3 Files changed 2 +197 -25

ash commented 2026-03-02 22:57:06 +00:00

Owner

Copy link

Fixes #171

One PG connection can hold thousands of advisory locks (session-scoped). Previous impl used one connection per lock, exhausting the pool.

Before: N locks = N connections held permanently
After: N locks = 1 connection

Changes:

• Single shared connection protected by mutex
• Refcount tracks held locks
• Auto-reconnect on stale connection
• Close() for clean shutdown

Fixes #171 One PG connection can hold thousands of advisory locks (session-scoped). Previous impl used one connection per lock, exhausting the pool. **Before:** N locks = N connections held permanently **After:** N locks = 1 connection Changes: - Single shared connection protected by mutex - Refcount tracks held locks - Auto-reconnect on stale connection - `Close()` for clean shutdown

ash added 1 commit 2026-03-02 22:57:07 +00:00

fix: PgLockRegistry uses single shared connection for all advisory locks ... 441a9040d9

One PG connection can hold thousands of advisory locks (session-scoped).
Previous impl used one connection per lock, exhausting the pool when many
subscriptions/automations were configured.

- Single shared connection protected by mutex
- Refcount tracks held locks, connection released when last lock released
- Auto-reconnect on stale connection (PG restart)
- Close() for clean shutdown

Closes #171

ash added 1 commit 2026-03-02 23:01:10 +00:00

fix: reject reentrant advisory lock acquisition ... f98c6a4e14

Advisory locks are reentrant within the same PG session — same connection
acquiring the same lock silently succeeds. With shared connection, this means
TryAcquire/Acquire on an already-held lock would incorrectly succeed.

Add app-level guard: check held map before calling PG. Return error (Acquire)
or false (TryAcquire) if lock already held by this registry.

ash added 1 commit 2026-03-02 23:02:05 +00:00

test: update lock tests for shared connection, add reentrancy and multi-lock tests ... 289c46e297

- SingleWriter: each goroutine gets own registry (simulates separate nodes)
- TryAcquire: uses two registries for cross-session contention
- New: ReentrantRejected — verifies same-registry double-acquire fails
- New: MultipleLocks_SharedConnection — 20 locks on 1 connection

ash merged commit 088cb853ee into main 2026-03-02 23:12:16 +00:00

ash referenced this pull request from a commit 2026-03-02 23:12:16 +00:00

Merge pull request 'fix: PgLockRegistry uses single shared connection for all advisory locks' (#172) from fix/shared-advisory-conn into main

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

bug

  

documentation

  

enhancement

  

investigation

  

nice-to-have

  

performance

  

production-ready

  

testing

No labels

bug

documentation

enhancement

investigation

nice-to-have

performance

production-ready

testing

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

ash/eskit!172

No description provided.