ClusterCommandHandler hardcodes json.Marshal — must use Codec #69

Closed
opened 2026-02-22 13:38:53 +00:00 by ash · 0 comments
Owner

Problem

cluster.go marshals commands/responses with encoding/json, ignoring the codec system. Breaks if events use CBOR or protobuf.

Fix

  • Accept Codec option in ClusterConfig
  • Use codec for all marshal/unmarshal in cluster communication
  • Default to JSON codec if none specified

Acceptance

  • ClusterCommandHandler uses Codec interface
  • Works with CBOR, protobuf, any custom codec
  • Tests with non-JSON codec
## Problem cluster.go marshals commands/responses with encoding/json, ignoring the codec system. Breaks if events use CBOR or protobuf. ## Fix - Accept Codec option in ClusterConfig - Use codec for all marshal/unmarshal in cluster communication - Default to JSON codec if none specified ## Acceptance - [ ] ClusterCommandHandler uses Codec interface - [ ] Works with CBOR, protobuf, any custom codec - [ ] Tests with non-JSON codec
ash closed this issue 2026-02-22 15:08:58 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
ash/eskit#69
No description provided.