mem: remove deprecated watcher.go, serializer.go, registry_store.go #231

New issue

Closed

opened 2026-03-10 10:13:49 +00:00 by ash · 0 comments

ash commented

2026-03-10 10:13:49 +00:00

Owner

Problem

Three files are fully deprecated with replacements available:

File	Lines	Replacement
`watcher.go`	352	`subscription/` package
`serializer.go`	207	`codec.Codec` interface
`registry_store.go`	269	`eskit.Register[E](reg)`

Total: 828 lines of dead code that:

Inflates binary size
Confuses new users (which API do I use?)
Requires maintenance (must compile, must not break)
Clutters godoc

Solution

Check no internal code depends on these (only external users, who were warned by deprecation)
Delete all three files and their test files
Update README/docs to remove references
Major version bump consideration (breaking change for anyone still using deprecated API)

Pillar: Memory Efficiency, Developer Experience

## Problem Three files are fully deprecated with replacements available: | File | Lines | Replacement | |------|-------|-------------| | `watcher.go` | 352 | `subscription/` package | | `serializer.go` | 207 | `codec.Codec` interface | | `registry_store.go` | 269 | `eskit.Register[E](reg)` | Total: **828 lines** of dead code that: - Inflates binary size - Confuses new users (which API do I use?) - Requires maintenance (must compile, must not break) - Clutters godoc ## Solution 1. Check no internal code depends on these (only external users, who were warned by deprecation) 2. Delete all three files and their test files 3. Update README/docs to remove references 4. Major version bump consideration (breaking change for anyone still using deprecated API) ## Pillar: Memory Efficiency, Developer Experience