perf: sqlitestore — deduplicate event scanning functions #227

New issue

Closed

opened 2026-03-10 10:13:17 +00:00 by ash · 0 comments

ash commented

2026-03-10 10:13:17 +00:00

Owner

Problem

sqlitestore/store.go has 5 nearly identical event scanning functions (lines ~530-970) that each:

Parse timestamps with time.Parse
Unmarshal JSON metadata with json.Unmarshal
Convert string IDs to int64
Build event structs

This is ~400 lines of copy-pasted code.

Solution

Extract a single generic scanEvent[E any]() or scanRawEvent() helper. All 5 call sites use it.

Benefits:

Single place to optimize (fewer cache misses from less code)
Single place to fix bugs (error handling, see related silent-error issue)
~300 lines removed

Pillar: Performance, Code Readability

## Problem `sqlitestore/store.go` has 5 nearly identical event scanning functions (lines ~530-970) that each: 1. Parse timestamps with `time.Parse` 2. Unmarshal JSON metadata with `json.Unmarshal` 3. Convert string IDs to int64 4. Build event structs This is ~400 lines of copy-pasted code. ## Solution Extract a single generic `scanEvent[E any]()` or `scanRawEvent()` helper. All 5 call sites use it. **Benefits:** - Single place to optimize (fewer cache misses from less code) - Single place to fix bugs (error handling, see related silent-error issue) - ~300 lines removed ## Pillar: Performance, Code Readability